bernardodemarco commented on code in PR #11766:
URL: https://github.com/apache/cloudstack/pull/11766#discussion_r2392801994
##########
ui/package.json:
##########
@@ -101,15 +101,18 @@
"eslint-plugin-vue": "^7.0.0",
"less": "^3.0.4",
"less-loader": "^5.0.0",
+ "nan": "2.18.0",
Review Comment:
@CodeBleu, since the UI has been correctly built, indeed, those new/changed
NPM packages are unrelated. If the code changes depended on them, then the
build process would have failed.
> I'm assuming it's because that environment is not building in the
https://github.com/apache/cloudstack/pull/11568 changes?
Yes, exactly. AFAIK, the backend of the QA env is currently built upon the
`4.21.0.0` version. Given that #11568 was targeted to the `4.22` milestone,
its changes are not included in the env
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
