DaanHoogland commented on code in PR #11824:
URL: https://github.com/apache/cloudstack/pull/11824#discussion_r2428037454
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.java:
##########
@@ -78,12 +78,12 @@ public long getEntityOwnerId() {
@Override
public String getEventDescription() {
- return "disabling user: " + getId();
+ return "disabling user: " + this._uuidMgr.getUuid(User.class, getId());
Review Comment:
> @DaanHoogland, I did not understand what "more generic event utility"
means. For me, the `UUIDManager.getUUID()` method is as generic as it can be.
Could you try to explain a little more of what is your idea?
have the method `getId()` be replaced by a method `getUuid()` that takes
care of it, for instance. We are sure to have to do a lot of replacements so I
have no real preference, but having three dots (.), two method calls and a type
passing seems not as generic as we can make it. I do not think we should perse
do it in one of these two PRs, this and #11649) but let’s think about it. We
are sure to have more occurrences like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
