Copilot commented on code in PR #12000:
URL: https://github.com/apache/cloudstack/pull/12000#discussion_r2498098594
##########
ui/src/views/infra/network/IpRangesTabPublic.vue:
##########
@@ -220,6 +220,20 @@
<a-select-option v-for="pod in pods" :key="pod.id" :value="pod.id"
:label="pod.name">{{ pod.name }}</a-select-option>
</a-select>
</a-form-item>
+ <a-form-item name="isolationmethod" ref="isolationmethod"
class="form__item" v-if="!basicGuestNetwork">
+ <tooltip-label :title="$t('label.isolation.method')"
:tooltip="$t('label.choose.isolation.method.public.ip.range')"
class="tooltip-label-wrapper"/>
+ <a-select
+ v-model:value="form.isolationmethod"
+ showSearch
+ optionFilterProp="label"
+ :filterOption="(input, option) => {
+ return option.label.toLowerCase().indexOf(input.toLowerCase())
>= 0
+ }" >
+ <a-select-option value="">{{ }}</a-select-option>
Review Comment:
The empty select option has an empty template expression `{{ }}`. This
should either display a label like 'None' or 'Default' to indicate the default
option, or the template expression should be removed entirely if no label is
intended.
```suggestion
<a-select-option value="">{{ $t('label.none')
}}</a-select-option>
```
##########
ui/src/views/infra/network/IpRangesTabPublic.vue:
##########
@@ -220,6 +220,20 @@
<a-select-option v-for="pod in pods" :key="pod.id" :value="pod.id"
:label="pod.name">{{ pod.name }}</a-select-option>
</a-select>
</a-form-item>
+ <a-form-item name="isolationmethod" ref="isolationmethod"
class="form__item" v-if="!basicGuestNetwork">
+ <tooltip-label :title="$t('label.isolation.method')"
:tooltip="$t('label.choose.isolation.method.public.ip.range')"
class="tooltip-label-wrapper"/>
+ <a-select
+ v-model:value="form.isolationmethod"
+ showSearch
+ optionFilterProp="label"
+ :filterOption="(input, option) => {
+ return option.label.toLowerCase().indexOf(input.toLowerCase())
>= 0
+ }" >
+ <a-select-option value="">{{ }}</a-select-option>
+ <a-select-option value="vlan"> vlan </a-select-option>
+ <a-select-option value="vxlan"> vxlan </a-select-option>
Review Comment:
[nitpick] The option labels 'vlan' and 'vxlan' should be capitalized to
'VLAN' and 'VXLAN' for consistency with technical terminology and better UI
presentation.
```suggestion
<a-select-option value="vlan"> VLAN </a-select-option>
<a-select-option value="vxlan"> VXLAN </a-select-option>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
