DaanHoogland commented on code in PR #11992:
URL: https://github.com/apache/cloudstack/pull/11992#discussion_r2498627623
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -2326,7 +2326,8 @@ public void prepareAllNicsForMigration(final
VirtualMachineProfile vm, final Dep
for (final NetworkElement element : networkElements) {
if (providersToImplement.contains(element.getProvider())) {
if
(!_networkModel.isProviderEnabledInPhysicalNetwork(_networkModel.getPhysicalNetworkId(network),
element.getProvider().getName())) {
- throw new CloudRuntimeException(String.format("Service
provider %s either doesn't exist or is not enabled in physical network: %s",
element.getProvider().getName(),
_physicalNetworkDao.findById(network.getPhysicalNetworkId())));
+ throw new CloudRuntimeException("Service provider " +
element.getProvider().getName() + " either doesn't exist or is not enabled in
physical network id: "
+ + network.getPhysicalNetworkId());
Review Comment:
why not use String.format anymore in this bit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
