Copilot commented on code in PR #12004:
URL: https://github.com/apache/cloudstack/pull/12004#discussion_r2498803549
##########
setup/bindir/cloud-setup-databases.in:
##########
@@ -199,6 +199,10 @@ for full help
self.info("No mysql root user specified, will not create Cloud DB
schema\n", None)
return
+ if self.areCloudDatabasesCreated() and not self.options.schemaonly and
not self.options.forcerecreate:
+ self.errorAndExit("Aborting script as the databases (cloud,
cloud_usage) already exist.\n" \
+ "Please use the --force-recreate parameter if
you want to recreate the schemas.")
Review Comment:
The error message should also mention the `--schema-only` option as an
alternative way to proceed when databases already exist. The current message
only mentions `--force-recreate`, but the condition now also allows the script
to continue when `--schema-only` is used. Consider updating the message to:
"Please use the --force-recreate parameter if you want to recreate the schemas,
or use --schema-only if you only want to update the schema."
```suggestion
"Please use the --force-recreate parameter if
you want to recreate the schemas, or use --schema-only if you only want to
update the schema.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
