DaanHoogland commented on code in PR #12028:
URL: https://github.com/apache/cloudstack/pull/12028#discussion_r2522058643
##########
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java:
##########
@@ -67,11 +67,13 @@ String removeCommandSensitiveInfoForLogging(String command)
{
public ProcessRunner(ExecutorService executor) {
this.executor = executor;
commandLogReplacements.add(new Ternary<>("ipmitool", "-P\\s+\\S+", "-P
*****"));
+ commandLogReplacements.add(new Ternary<>("ipmitool",
"(?i)(password)(\\s+)\\S+(\\s+)\\S+", "$1 ****$2****"));
Review Comment:
@YLChen-007 , can you give us some insight as to why you consider this
resolved without applying, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
