GutoVeronezi commented on PR #12184: URL: https://github.com/apache/cloudstack/pull/12184#issuecomment-3629171044
> > regression tests make no sense as testing this will need destructive action on an env. @soreana , any insights to share? > > I’m not sure how this issue is related to my PR. I didn’t change the `listByPhysicalNetworkTrafficType` method in NetworkDaoImpl.java. My change only checks whether the network has at most one tag with null traffic. Let me know if you need more clarification testing, I can have a look later this week. Hello @soreana, The PR #6871 changed the `and` operator for `AllFieldsSearch` on line 132 of the file: https://github.com/apache/cloudstack/pull/6781/files#diff-1581a1045b0596815f553a6cd480c708dd25e29f7042d7b053dba51a19f5bf34 <img width="2438" height="465" alt="image" src="https://github.com/user-attachments/assets/5db7e860-3740-4973-8b0d-5c2062d762e5"; /> `AllFieldsSearch` with the physical network ID was only used on `listByPhysicalNetworkTrafficType`. As the PRs renamed the parameter from `physicalNetwork` to `physicalNetworkId` on line 132 but didn't change where it called the `setParameters` method, the filter stopped working. Also, refer to https://github.com/apache/cloudstack/pull/6510/files#r908135825. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
