DaanHoogland commented on code in PR #12187:
URL: https://github.com/apache/cloudstack/pull/12187#discussion_r2601960117
##########
systemvm/agent/noVNC/app/ui.js:
##########
@@ -1740,6 +1753,44 @@ const UI = {
UI.idleControlbar();
},
+ _sendKeyUp(keysym, code) {
+ if (!UI.rfb) return;
+ UI.rfb.sendKey(keysym, code, false);
+ },
+
+ // Release a single modifier key if it's pressed
+ _releaseModifierKey(keyName) {
+ const keyConfig = UI._modifierKeys[keyName];
+ if (!keyConfig) return false;
+
+ const btn = document.getElementById(keyConfig.buttonId);
+ if (!btn || !btn.classList.contains("noVNC_selected")) {
+ return false;
+ }
+
+ UI._sendKeyUp(keyConfig.keysym, keyConfig.code);
+ btn.classList.remove("noVNC_selected");
+ return true;
+ },
+
+ // Release all currently pressed modifier keys
+ _releaseAllModifierKeys() {
+ if (!UI.rfb) {
+ return false;
+ }
Review Comment:
is this needed if it is already in `_sendKeyUp()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
