Pearl1594 commented on code in PR #12228:
URL: https://github.com/apache/cloudstack/pull/12228#discussion_r2607245801
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -1869,6 +1869,18 @@ public Network createGuestNetwork(long
networkOfferingId, String name, String di
null, null, null, null, null, null, null, null, null, null);
}
+ @Override
+ @DB
+ @ActionEvent(eventType = EventTypes.EVENT_NETWORK_CREATE, eventDescription
= "creating network")
+ public Network createGuestNetwork(long networkOfferingId, String name,
String displayText, Account owner,
+ PhysicalNetwork physicalNetwork, long
zoneId, ACLType aclType, Pair<Integer, Integer> vrIfaceMTUs) throws
+ InsufficientCapacityException, ConcurrentOperationException,
ResourceAllocationException {
+ return _networkMgr.createGuestNetwork(networkOfferingId, name,
displayText,
Review Comment:
I did consider that, but found value in creating a method that takes MTU as
a parameter - which "probably" could be reused in future at other places, and
it's simpler as it hides a lot of the low level parameters that
NetworkManager::createGuestNetwork expects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
