shwstppr commented on code in PR #11567:
URL: https://github.com/apache/cloudstack/pull/11567#discussion_r2625935073
##########
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java:
##########
@@ -980,7 +980,7 @@ public BackupProvider getBackupProvider(final String name) {
@Override
public List<Class<?>> getCommands() {
final List<Class<?>> cmdList = new ArrayList<Class<?>>();
- if (!BackupFrameworkEnabled.value()) {
+ if (!BackupFrameworkEnabled.value() &&
!BackupFrameworkEnabled.hasValueInScope(Boolean.TRUE.toString())) {
Review Comment:
@sureshanaparti I understand that, but won't it create an issue in UI
showing backup-related options for zones and for zone resources where backup
feature is not enabled?
eg: assignVirtualMachineToBackupOffering action will start showing for all
VMs, deploy VM form will start showing backup options even for zone where
option isn't available.
Though, this could be currently true for the other way around as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
