weizhouapache commented on PR #10868:
URL: https://github.com/apache/cloudstack/pull/10868#issuecomment-3674026128

   > clgtm, I agree changing the new global setting to have the default value 
as `false` to keep the current behavior.
   
   yes, the default value should be `false`
   
   @erikbocks 
   can you rebase with 4.20 ? we do not maintain 4.19 any more.
   for the global setting name, `enable.login.saml.unathourized` implies the 
saml user is unathourized, not disabled. should it be changed ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to