shwstppr commented on code in PR #12296:
URL: https://github.com/apache/cloudstack/pull/12296#discussion_r2634425629
##########
engine/components-api/src/main/java/com/cloud/storage/StorageManager.java:
##########
@@ -220,8 +220,9 @@ public interface StorageManager extends StorageService {
"storage.pool.host.connect.workers", "1",
"Number of worker threads to be used to connect hosts to a primary
storage", true);
- ConfigKey<Boolean> COPY_PUBLIC_TEMPLATES_FROM_OTHER_STORAGES = new
ConfigKey<>(Boolean.class, "copy.public.templates.from.other.storages",
- "Storage", "true", "Allow SSVMs to try copying public templates
from one secondary storage to another instead of downloading them from the
source.",
+ ConfigKey<Boolean> COPY_TEMPLATES_FROM_OTHER_SECONDARY_STORAGES = new
ConfigKey<>(Boolean.class, "copy.templates.from.other.secondary.storages",
Review Comment:
I think this will not replace the existing config but will add a new one. We
may need a change in the upgrade path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
