vishesh92 commented on code in PR #12294:
URL: https://github.com/apache/cloudstack/pull/12294#discussion_r2644924000
##########
server/src/main/java/com/cloud/user/AccountManagerImpl.java:
##########
@@ -2847,6 +2862,8 @@ public UserAccount authenticateUser(final String
username, final String password
logger.debug(String.format("User: %s in domain %d has
successfully logged in, auth time duration - %d ms", username, domainId,
validUserLastAuthTimeDurationInMs));
}
+ user.setDetails(_userDetailsDao.listDetailsKeyPairs(user.getId()));
Review Comment:
What is this for?
##########
ui/src/store/modules/user.js:
##########
@@ -485,6 +511,9 @@ const user = {
vueProps.$localStorage.remove(ACCESS_TOKEN)
vueProps.$localStorage.remove(HEADER_NOTICES)
+ vueProps.$localStorage.remove(PASSWORD_CHANGE_REQUIRED)
+ commit('SET_PASSWORD_CHANGE_REQUIRED', false)
Review Comment:
Shouldn't `commit('SET_PASSWORD_CHANGE_REQUIRED', false)` only be fine here.
```suggestion
commit('SET_PASSWORD_CHANGE_REQUIRED', false)
```
##########
api/src/main/java/org/apache/cloudstack/api/response/LoginCmdResponse.java:
##########
@@ -90,6 +90,10 @@ public class LoginCmdResponse extends
AuthenticationCmdResponse {
@Param(description = "Management Server ID that the user logged to", since
= "4.21.0.0")
private String managementServerId;
+ @SerializedName(value = ApiConstants.PASSWORD_CHANGE_REQUIRED)
+ @Param(description = "Indicates whether the User is required to change
password on next login.", since = "4.23.0")
+ private String passwordChangeRequired;
Review Comment:
Use boolean here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
