DaanHoogland commented on code in PR #12349:
URL: https://github.com/apache/cloudstack/pull/12349#discussion_r2652635890
##########
api/src/main/java/com/cloud/network/NetworkModel.java:
##########
@@ -125,6 +125,10 @@ public interface NetworkModel {
*/
String getNextAvailableMacAddressInNetwork(long networkConfigurationId)
throws InsufficientAddressCapacityException;
+ default boolean isMACUnique(String mac, long networkId) {
+ return true;
+ }
Review Comment:
yes, but it seems a logical error for anyone wanting to implement a new
`NetworkModel`. They should be forced to implement it and not use this code by
default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
