DaanHoogland commented on code in PR #12409:
URL: https://github.com/apache/cloudstack/pull/12409#discussion_r2685321740
##########
framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java:
##########
@@ -969,6 +969,13 @@ public void reallyRun() {
}
logger.trace("End cleanup expired async-jobs");
+
+ // 3) Cleanup orphaned networks stuck in Implementing
state without async jobs
+ try {
+ cleanupOrphanedNetworks();
+ } catch (Throwable e) {
+ logger.error("Unexpected exception when trying to
cleanup orphaned networks", e);
+ }
Review Comment:
there is a try catch as highest level inside `cleanupOrphanedNetworks()`, is
this one needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
