NVShawn commented on code in PR #12410:
URL: https://github.com/apache/cloudstack/pull/12410#discussion_r2687372175


##########
server/src/main/java/com/cloud/configuration/Config.java:
##########
@@ -351,6 +351,15 @@ public enum Config {
             ConfigKey.Kind.CSV,
             null),
 
+    DhcpLeaseTimeout(
+            "Network",
+            ManagementServer.class,
+            Integer.class,
+            "dhcp.lease.timeout",
+            "0",
+            "DHCP lease time in seconds for VMs. Use 0 for infinite lease time 
(default). A non-zero value sets the lease duration in seconds.",
+            null),

Review Comment:
   Updated PR according to suggestions, and moved the config key to 'Zone' 
scope. The more I think about it, the more that makes sense to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to