weizhouapache commented on PR #12408:
URL: https://github.com/apache/cloudstack/pull/12408#issuecomment-3750367086
> > > > @DaanHoogland as I understand, #10122 is a UI issue. Does this PR
fix other issues ?
> > >
> > >
> > > it is not a pure UI issue. The IP address is marked as source NAT in
the DB. I am not sure if this addresses all scenarios yet, but it will prevent
marking the primary IP for a ROUTED-mode network as source NAT.
> >
> >
> > ok @DaanHoogland it is becoming a PR with big impact then.
> > as I understand, what @msinhore wanted is the change of label of public
IP. `source nat` of routed network confuses users, need to change to "external
gateway" or so what ACS saves into database and how it is processed in the
service layer are not very important.
>
> isSourceNat is a flag returned to the UI, if we do not change it in the
service we have to honour that flag conditionally. Not a very clean solution
either and technical debt at the same time. I would suggest we fix it good or
not.
ok.
please bear in mind, Routed network requires a public IP for VR, as external
gateway IP.
you can set isSourceNat to false in response, but may need to add another
flag, for example isGateway which is set to true.
a simple workaround on UI
- if IP is source nat,
- if network is Routed, display "external gateway"
- if not, display "source nat"
- xxx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
