nvazquez commented on PR #12472:
URL: https://github.com/apache/cloudstack/pull/12472#issuecomment-3799211420

   Thanks for the reviews @harikrishna-patnala @DaanHoogland @RosiKyu - I have 
addressed the remaining review comment by adding the version as part of the 
keyword parameter search:
   
   - The previous behavior doesn't change: @RosiKyu the use cases tested will 
remain the same 
(https://github.com/apache/cloudstack/pull/12472#pullrequestreview-3698442086) 
   - The `keyword` parameter will also consider the version, using the LIKE 
operator:
   
   ````
   (localcloud) 🐱 > list hosts filter=id,name,state,version type=routing 
keyword=4.20
   {
     "count": 2,
     "host": [
       {
         "id": "4a7b573c-8b7d-4da9-be86-20f4a4640c91",
         "name": "ref-trl-10590-k-Mr8-nicolas-vazquez-kvm1",
         "state": "Up",
         "version": "4.20.3.0-SNAPSHOT"
       },
       {
         "id": "24b4a589-8df5-453a-a882-a87fc6949356",
         "name": "ref-trl-10590-k-Mr8-nicolas-vazquez-kvm2",
         "state": "Up",
         "version": "4.20.3.0-SNAPSHOT"
       }
     ]
   }
   (localcloud) 🐱 > list managementservers keyword=4.20 
filter=id,state,osdistribution,version
   {
     "count": 1,
     "managementserver": [
       {
         "id": "a44c9027-3909-441c-a792-b63d5799ac00",
         "osdistribution": "Rocky Linux 8.4 (Green Obsidian)",
         "state": "Up",
         "version": "4.20.3.0-SNAPSHOT"
       }
     ]
   }
   ````


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to