winterhazel commented on code in PR #12522:
URL: https://github.com/apache/cloudstack/pull/12522#discussion_r2733266346
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -527,7 +527,7 @@ public class ConfigurationManagerImpl extends ManagerBase
implements Configurati
public static final ConfigKey<Long> DELETE_QUERY_BATCH_SIZE = new
ConfigKey<>("Advanced", Long.class, "delete.query.batch.size", "0",
"Indicates the limit applied while deleting entries in bulk. With
this, the delete query will apply the limit as many times as necessary," +
" to delete all the entries. This is advised when
retaining several days of records, which can lead to slowness. <= 0 means that
no limit will " +
- "be applied. Default value is 0. For now, this is used for
deletion of vm & volume stats only.", true);
+ "be applied. Default value is 0. For now, this is used for
deletion of VM stats, volume stats, and usage records.", true);
Review Comment:
Yes, I think it would be good to enable batch deletion by default. 10,000 is
too low and might end up slowing down deletion too much though. I've seen
`vm_stats` with over 100 million entries for deletion, which would take too
long with batches of 10,000. I will check how some different values behave
later.
By the way, I'm putting this in draft because I noticed an issue in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
