shwstppr commented on code in PR #12092:
URL: https://github.com/apache/cloudstack/pull/12092#discussion_r2781765112
##########
engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java:
##########
@@ -108,9 +108,19 @@ public class SystemVmTemplateRegistration {
private static Integer LINUX_12_ID = 363;
private static final Integer SCRIPT_TIMEOUT = 1800000;
private static final Integer LOCK_WAIT_TIMEOUT = 1200;
- protected static final List<CPU.CPUArch> DOWNLOADABLE_TEMPLATE_ARCH_TYPES
= Arrays.asList(
- CPU.CPUArch.arm64
+ protected static final List<Pair<Hypervisor.HypervisorType, CPU.CPUArch>>
AVAILABLE_SYSTEM_TEMPLATES_HYPERVISOR_ARCH_LIST = Arrays.asList(
+ new Pair<>(Hypervisor.HypervisorType.KVM, CPU.CPUArch.amd64),
+ new Pair<>(Hypervisor.HypervisorType.KVM, CPU.CPUArch.arm64),
+ new Pair<>(Hypervisor.HypervisorType.VMware, CPU.CPUArch.amd64),
+ new Pair<>(Hypervisor.HypervisorType.XenServer, CPU.CPUArch.amd64),
+ new Pair<>(Hypervisor.HypervisorType.Hyperv, CPU.CPUArch.amd64),
+ new Pair<>(Hypervisor.HypervisorType.LXC, CPU.CPUArch.amd64),
+ new Pair<>(Hypervisor.HypervisorType.Ovm3, CPU.CPUArch.amd64)
Review Comment:
@DaanHoogland currently we cannot run system VMs with External hypervisor.
I checked we do have system templates for HyperV and OVM here,
https://download.cloudstack.org/systemvm/4.22/
I can remove LXC for now and remaining when they are removed or in `main`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
