bernardodemarco commented on PR #9504: URL: https://github.com/apache/cloudstack/pull/9504#issuecomment-4005157892
@shwstppr @sureshanaparti @DaanHoogland @weizhouapache @GutoVeronezi @winterhazel @JoaoJandre @hsato03 @erikbocks, guys, this one is finally ready for review and testing. Below are the test descriptions that I have performed: | N° | Test | Description | Expected result? | | -- | ---- | ----------- | ---------------- | | 1 | Key pair without explicit rules | Verified that when creating a key pair without explicit rules, all the account's role permissions are inferred as the permissions of the key pair. | Yes | | 2 | Key pair with explicit rules | Verified that when creating a key pair with explicit rules, it is only granted access to the key pair's rules. | Yes | | 3 | Change account's role rules after API keys have been created. | Verified that the key pair never has access to more APIs that its role has. | Yes | | 4 | Key pairs creation with more permissions that the caller's role | Verified that it is not possible to create key pairs with more permission than the caller's set of permissions. | Yes | | 5 | Key pair with start and end dates. | Verified that the `startdate` and `enddate` attributes of the key pair are correctly respected. | Yes | | 6 | Key pairs creation from the UI. | Accessed the details page of an user and successfully generated an API key pair for it. | Yes | | 7 | Invalidation of API key pairs after user/account deletion | Verified that after deleting accounts and users, their API key pairs are correctly deleted. | Yes | | 8 | Invalidation of API key pairs when they are disabled | Verified that it is not possible to use the API key pairs when they are disabled for their accounts and users. | Yes | | 9 | High-level workflows of the APIs `getUserKeys`, `registerUserKeys`, `deleteUserKeys`, `listUserKeyRules`, `listUserKeys` | Verified the execution of such APIs, including access validation checks. | Yes | | 10 | Deletion of system keys | Tried to delete the keys of the `baremetal-system-account` account and verified that an error message was returned. Verified the possibility of removing the key pair when the `baremetal.provision.done.notification` is disabled. | Yes | | 11 | Migration to the new DB's schema | Verified that the migration of active API key pairs from the `cloud.user` table to the `cloud.api_keypair` one was performed successfully. | Yes | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
