weizhouapache commented on code in PR #12767:
URL: https://github.com/apache/cloudstack/pull/12767#discussion_r2906514864
##########
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##########
@@ -1017,6 +1017,10 @@ public PrimaryDataStoreInfo
createPool(CreateStoragePoolCmd cmd) throws Resource
if (Grouping.AllocationState.Disabled == zone.getAllocationState() &&
!_accountMgr.isRootAdmin(account.getId())) {
throw new PermissionDeniedException(String.format("Cannot perform
this operation, Zone is currently disabled: %s", zone));
}
+ // Check if it's local storage and if it's enabled on the zone
+ if (isFileScheme && !zone.isLocalStorageEnabled()) {
+ throw new InvalidParameterValueException("Local storage is not
enabled for zone: " + zone);
+ }
Review Comment:
@vishesh92
looks like valid point, can you have a look ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
