weizhouapache commented on code in PR #12773: URL: https://github.com/apache/cloudstack/pull/12773#discussion_r2912855462
########## scripts/vm/hypervisor/kvm/kvmsmpheartbeat.sh: ########## @@ -0,0 +1,218 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +help() { + printf "Usage: $0 + -i identifier (ignored for local-only heartbeat) + -p path (ignored for local-only heartbeat) + -m mount point (local path where heartbeat will be written) + -h host (host IP/name to include in heartbeat filename) + -r write/read hb log (read-check mode) + -c cleanup (trigger emergency reboot) + -t interval between read hb log\n" + exit 1 +} + +#set -x +NfsSvrIP= +NfsSvrPath= +MountPoint= +HostIP= +interval= +rflag=0 +cflag=0 + +while getopts 'i:p:m:h:t:rc' OPTION +do + case $OPTION in + i) + NfsSvrIP="$OPTARG" + ;; # retained for CLI compatibility but unused for local-only script + p) + NfsSvrPath="$OPTARG" + ;; # retained for CLI compatibility but unused for local-only script + m) + MountPoint="$OPTARG" + ;; + h) + HostIP="$OPTARG" + ;; + r) + rflag=1 + ;; + t) + interval="$OPTARG" + ;; + c) + cflag=1 + ;; + *) + help + ;; + esac +done + +# Match original kvmheartbeat.sh: require NfsSvrIP parameter for CLI compatibility +if [ -z "$NfsSvrIP" ] +then + exit 1 +fi + +# For local-only heartbeat we require a mountpoint +if [ -z "$MountPoint" ] +then + echo "Mount point (-m) is required" + help +fi + +# Ensure mount point exists and is writable +if [ ! -d "$MountPoint" ]; then + mkdir -p "$MountPoint" 2>/dev/null + if [ $? -ne 0 ]; then + echo "Failed to create mount point directory: $MountPoint" >&2 + exit 1 + fi +fi + +# Determine a sensible HostIP if not provided +if [ -z "$HostIP" ]; then + # try to get a non-loopback IPv4 address, fallback to hostname + ipaddr=$(hostname -I 2>/dev/null | awk '{print $1}') + if [ -n "$ipaddr" ]; then + HostIP="$ipaddr" + else + HostIP=$(hostname) + fi +fi + +#delete VMs on this mountpoint (best-effort) +deleteVMs() { + local mountPoint=$1 + vmPids=$(ps aux | grep qemu | grep "$mountPoint" | awk '{print $2}' 2> /dev/null) + if [ $? -gt 0 ] + then + return + fi + + if [ -z "$vmPids" ] + then + return + fi + + for pid in $vmPids + do + kill -9 $pid &> /dev/null + done +} + +#checking is there the mount point present under $MountPoint? +mounts=$(cat /proc/mounts | grep "$MountPoint") +if [ $? -gt 0 ] +then + # mount point not present — we don't remount in local-only script + # nothing to do here; keep for compatibility with original flow + : +else Review Comment: ```suggestion mounts=$(cat /proc/mounts | grep "$MountPoint ") if [ $? -gt 0 ] then # mount point not present — we don't remount in local-only script # nothing to do here; keep for compatibility with original flow : else ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
