nvazquez commented on code in PR #12597:
URL: https://github.com/apache/cloudstack/pull/12597#discussion_r2918717117
##########
engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/SnapshotDataStoreDaoImpl.java:
##########
@@ -387,6 +400,15 @@ public SnapshotDataStoreVO
findBySnapshotIdAndDataStoreRoleAndState(long snapsho
return findOneBy(sc);
}
+ @Override
+ public List<SnapshotDataStoreVO>
findBySnapshotIdAndDataStoreRoleAndStateIn(long snapshotId, DataStoreRole role,
State... state) {
Review Comment:
Very minor: usually with `find` methods we would expect one item to be
retrieved, in this case I think `list` would be more suitable for this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
