Copilot commented on code in PR #12807: URL: https://github.com/apache/cloudstack/pull/12807#discussion_r2929005204
########## engine/schema/src/main/resources/META-INF/db/schema-42200to42210.sql: ########## @@ -33,3 +33,5 @@ UPDATE `cloud`.`alert` SET type = 34 WHERE name = 'ALERT.VR.PRIVATE.IFACE.MTU'; -- Update configuration 'kvm.ssh.to.agent' description and is_dynamic fields UPDATE `cloud`.`configuration` SET description = 'True if the management server will restart the agent service via SSH into the KVM hosts after or during maintenance operations', is_dynamic = 1 WHERE name = 'kvm.ssh.to.agent'; + +DELETE FROM `cloud`.`configuration` WHERE name = 'consoleproxy.cmd.port'; Review Comment: Deleting `consoleproxy.cmd.port` from `cloud.configuration` in the upgrade script won’t actually remove the setting long-term: on next management server start, `ConfigDepotImpl.populateConfiguration` will recreate any missing rows for registered `ConfigKey`s, and `ConsoleProxyManager` / `ConsoleProxyManagerImpl.getConfigKeys()` still register `consoleproxy.cmd.port`. This also means any previously stored value will be reset to the default when the row is re-created. To truly remove this unused config, also remove the `ConsoleProxyCmdPort` `ConfigKey` (and its inclusion in `getConfigKeys()`), plus any related test/seed mappings (e.g. `DatabaseConfig`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
