abh1sar commented on PR #12848: URL: https://github.com/apache/cloudstack/pull/12848#issuecomment-4115233720
Hi @jmsperu Thanks for your PRs on NAS backup improvements. Regarding this PR and https://github.com/apache/cloudstack/pull/12844, just adding a flag in nasbackup.sh doesn't change anything for the user. It has to be paired with changes in the cloudstack-agent code LibvirtTakeBackupCommandWrapper which invokes the script. The new flags have to be set there, and they should be stored as a global/zone scope config in the management server which are passed by the management server to the kvm agent via the TakeBackupCommand. Would you be able to make the above change? One more suggestion is that it would be easier for reviewers and testers to work on the PRs if they are combined into one PRs as they all deal with adding new flags to nasbackup.sh? If you prefer you can have them as separate commits and they will be merged as separate commits to the apache CloudStack codebase. Please see which of your PRs can be combined. Thanks again for your efforts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
