owsferraro commented on code in PR #12880:
URL: https://github.com/apache/cloudstack/pull/12880#discussion_r2983119069
##########
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/ScaleIOVMSnapshotStrategy.java:
##########
@@ -201,11 +202,44 @@ public VMSnapshot takeVMSnapshot(VMSnapshot vmSnapshot) {
List<VMSnapshotDetailsVO> vmSnapshotDetails = new
ArrayList<VMSnapshotDetailsVO>();
vmSnapshotDetails.add(new
VMSnapshotDetailsVO(vmSnapshot.getId(), "SnapshotGroupId", snapshotGroupId,
false));
- for (int index = 0; index < volumeIds.size(); index++) {
+ /* for (int index = 0; index < volumeIds.size(); index++) {
String volumeSnapshotName =
srcVolumeDestSnapshotMap.get(ScaleIOUtil.getVolumePath(volumeTOs.get(index).getPath()));
String pathWithScaleIOVolumeName =
ScaleIOUtil.updatedPathWithVolumeName(volumeIds.get(index), volumeSnapshotName);
vmSnapshotDetails.add(new
VMSnapshotDetailsVO(vmSnapshot.getId(), "Vol_" + volumeTOs.get(index).getId() +
"_Snapshot", pathWithScaleIOVolumeName, false));
}
+ */
+ // Invert the srcVolumeDestSnapshotMap: snapshotName ->
srcVolumePath
Review Comment:
comment removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
