abh1sar opened a new pull request, #13019: URL: https://github.com/apache/cloudstack/pull/13019
### Description This PR fixes #12590 Fix is to remove the unique key constraint from the `usage_vm_instance` table. The constraint is not required, and can cause issues with usage processing. The other helper tables either don't have a constraint or duplicate events cannot happen as the event is generated only at create. In case of VM instance the event is generated at every Start which makes it susceptible to duplicate events. Added change in the upgrade path as well as in `create-schema-premium.sql` <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [x] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? To test, I added 2 VM.START events to the usage_event table with the same `created` time **(id 18 and 20)** and set the `usage.stats.job.aggregation.range` to 5 (minutes) <img width="3684" height="990" alt="image" src="https://github.com/user-attachments/assets/d0f35f7e-17cd-4257-a013-b896fb36eba5"; /> Without the fix the usage server was stuck processing that interval <img width="1791" height="457" alt="Screenshot 2026-04-14 at 10 44 21 AM" src="https://github.com/user-attachments/assets/18d52dcc-0fdd-4768-b9d3-48c56191d6b8"; /> After removing the unique constraint, usage server finished successfully and generated the correct usage. <img width="1796" height="808" alt="Screenshot 2026-04-14 at 10 52 26 AM" src="https://github.com/user-attachments/assets/416d0be0-2969-4f03-a75c-0608f8b7e1e9"; /> <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
