bernardodemarco commented on PR #12975: URL: https://github.com/apache/cloudstack/pull/12975#issuecomment-4246939826
Hello, @DaanHoogland > Do you think it makes sense to write an integration test for this? I've checked the existing integration tests in the codebase and identified the `test_17_running_vm_scaleup` test in `test_escalations_instances.py`, which already covers the VM live scaling workflow. However, since this feature was not previously available for KVM, the test included a constraint to skip execution when the active hypervisor is KVM. I removed this constraint, so we can now observe how the test behaves. I believe that this integration test is sufficient. Most of the changes in the PR are on the Agent side and are well covered by unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
