GaOrtiga commented on code in PR #12793:
URL: https://github.com/apache/cloudstack/pull/12793#discussion_r3093936595
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -9521,10 +9528,10 @@ public UserVm importVM(final DataCenter zone, final
Host host, final VirtualMach
final String uuidName = _uuidMgr.generateUuid(UserVm.class, null);
final Host lastHost = powerState !=
VirtualMachine.PowerState.PowerOn ? host : null;
- final Boolean dynamicScalingEnabled =
checkIfDynamicScalingCanBeEnabled(null, serviceOffering, template,
zone.getId());
- return commitUserVm(true, zone, host, lastHost, template,
hostName, displayName, owner,
+ final Boolean dynamicScalingEnabled =
checkIfDynamicScalingCanBeEnabled(null, serviceOffering, vmTemplateVO,
zone.getId());
+ return commitUserVm(true, zone, host, lastHost, vmTemplateVO,
hostName, displayName, owner,
null, null, userData, null, null, isDisplayVm, keyboard,
- accountId, userId, serviceOffering,
template.getFormat().equals(ImageFormat.ISO), sshPublicKeys, networkNicMap,
+ accountId, userId, serviceOffering,
vmTemplateVO.getFormat().equals(ImageFormat.ISO), sshPublicKeys, networkNicMap,
Review Comment:
@weizhouapache this suggestion seems valid,
`checkIfDynamicScalingCanBeEnabled` generates an NPE if the template is null,
we might as well throw an exception when checking for it on line `9513`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
