GaOrtiga commented on code in PR #12645:
URL: https://github.com/apache/cloudstack/pull/12645#discussion_r3094083887
##########
ui/src/views/network/CreateIsolatedNetworkForm.vue:
##########
@@ -515,13 +521,17 @@ export default {
if (this.vpc !== null) { // from VPC section
this.fetchNetworkOfferingData(true)
} else { // from guest network section
- var params = {}
+ var params = {
+ account: this.owner.account,
+ projectid: this.owner.projectid,
+ domainid: this.owner.domainid
+ }
this.networkOfferingLoading = true
if ('listVPCs' in this.$store.getters.apis) {
api('listVPCs', params).then(json => {
const listVPCs = json.listvpcsresponse.vpc
- var vpcAvailable = this.arrayHasItems(listVPCs)
- if (vpcAvailable === false) {
+ this.hasVPC = this.arrayHasItems(listVPCs)
+ if (this.hasVPC === false) {
this.fetchNetworkOfferingData(false)
} else {
this.fetchNetworkOfferingData()
Review Comment:
@erikbocks I did not dig in this code too deep, if these are not
equivalente, you can just disregard this suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
