erikbocks commented on PR #13001:
URL: https://github.com/apache/cloudstack/pull/13001#issuecomment-4274966177
CLGTM. Tested it locally, and below are the test cases and their results:
| Number | Test case
| Expected behavior
| Observed behavior |
|--------|------------------------------------------------------------------------------------|-------------------------------------------------------------------------|----------------------------------------------------------|
| 1 | Restart with cleanup of an Isolated network with
`keepmacaddressonpublicnic=true` | The VR’s public NIC retains the same MAC
address after restart | The new VR’s public NIC retained the same MAC
address |
| 2 | Restart with cleanup of an Isolated network with
`keepmacaddressonpublicnic=false` | The VR’s public NIC gets a new MAC address
after restart | The new VR’s public NIC MAC address changed
|
| 3 | Create a redundant Isolated network with
`keepmacaddressonpublicnic=true` | Both VRs have the same MAC address
on their public NICs | Both VRs had the same MAC address on
their public NICs |
| 4 | Create a redundant Isolated network with
`keepmacaddressonpublicnic=false` | Each VR has a different MAC address
on its public NIC | The VRs had different MAC addresses on
their public NICs |
| 5 | Restart with cleanup of a VPC with
`keepmacaddressonpublicnic=true` | The VR’s public NIC retains
the same MAC address after restart | The new VR’s public NIC retained
the same MAC address |
| 6 | Restart with cleanup of a VPC with
`keepmacaddressonpublicnic=false` | The VR’s public NIC gets a
new MAC address after restart | The new VR’s public NIC MAC
address changed |
| 7 | Create a redundant VPC with `keepmacaddressonpublicnic=true`
| Both VRs have the same MAC address on their public NICs
| Both VRs had the same MAC address on their public NICs |
| 8 | Create a redundant VPC with `keepmacaddressonpublicnic=false`
| Each VR has a different MAC address on its public NIC
| The VRs had different MAC addresses on their public NICs |
| 9 | Restart with cleanup of a redundant VPC with
`keepmacaddressonpublicnic=true` | Both VRs retain the same MAC address on
their public NICs after restart | Both VRs had the same MAC address on their
public NICs |
| 10 | Restart with cleanup of a redundant VPC with
`keepmacaddressonpublicnic=false` | Each VR has a different MAC address on
its public NIC after restart | The VRs had different MAC addresses on their
public NICs |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
