dheeraj12347 opened a new pull request, #13058:
URL: https://github.com/apache/cloudstack/pull/13058
### Description
This PR backports the console proxy/noVNC timeout fix to the 4.20 branch.
It ensures that `consoleproxy.session.timeout` is honoured for noVNC console
sessions, so idle sessions are cleaned up correctly and do not linger
indefinitely.
Key points:
- Wire `consoleproxy.session.timeout` through the console proxy server for
noVNC-based console sessions.
- Apply the timeout in the WebSocket handler and GC thread so idle sessions
are closed after the configured period.
- Keep the change minimal and compatible with 4.20: do not introduce the
newer `sessionRequiresNewViewer` API on `ConsoleProxyClientParam`, only
remove the references that exist in later branches.
### Related work
- Backport of the console proxy timeout fix from the main branch.
- Intended to address the same behaviour as the upstream change that fixed
idle noVNC sessions not respecting `consoleproxy.session.timeout`.
### Testing
- Compiled the console proxy server module successfully:
```bash
mvn -pl services/console-proxy/server -am -DskipTests compile
```
- Verified that the code builds cleanly with checkstyle on the 4.20 branch.
Fix #12810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
