winterhazel commented on code in PR #13048:
URL: https://github.com/apache/cloudstack/pull/13048#discussion_r3126219051
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -4347,7 +4344,7 @@ private UserVm getUncheckedUserVmResource(DataCenter
zone, String hostName, Stri
List<CheckedReservation> checkedReservations = new ArrayList<>();
try {
- checkedReservations = reserveStorageResourcesForVm(owner,
diskOfferingId, diskSize, dataDiskInfoList, rootDiskOfferingId, offering,
volumesSize);
+ reserveStorageResourcesForVm(checkedReservations, owner,
diskOfferingId, diskSize, dataDiskInfoList, rootDiskOfferingId, offering,
volumesSize);
Review Comment:
The existing tests that mock `CheckedReservation` are not related to this
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
