genegr commented on PR #13060: URL: https://github.com/apache/cloudstack/pull/13060#issuecomment-4305026588
Pushed `929f88a88d flasharray: address review on login()` to address this round of feedback: - **`if (!apiVersionExplicit)`** instead of `if (apiVersion == null)` on both the connection-details branch and the query-params branch (@sureshanaparti). Semantically equivalent — now reads "explicitly configured?" which is what the logic actually means. - **`vResp.close()` in the `/api/api_version` finally is now wrapped in try/catch**, logging any `IOException` at `debug` so a failed close cannot mask an otherwise-successful version discovery (@Copilot). - **`response.close()` after the legacy username/password exchange is now wrapped in try/catch** with the same debug-level log, for the same reason (@Copilot). Smoke-tested locally: login via `api_token` (2.x-only path) and login via username/password (deprecation-warning path) both succeed; pool capacity polling and volume create still work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
