genegr commented on PR #13059: URL: https://github.com/apache/cloudstack/pull/13059#issuecomment-4305065179
Pushed `0970c239c1 adaptive: address review on capacityBytes validation` to address the new round of Copilot feedback: - **`capacityBytes > 0` instead of `capacityBytes != 0`** on the guarded block — a negative value now falls through to the "no user-provided capacity" branch rather than being persisted as garbage capacity (@Copilot line 229). The existing "zero == not provided" semantics are preserved. - **Exception message reworded** to "Provided capacity bytes exceed the capacity of the storage endpoint" (@Copilot line 227). ### About the `build` check failure (@sureshanaparti) I looked into the GHA `build` failure on the previous head `25641c3938` and it's a **Maven file-lock contention timeout**, unrelated to this PR's code: ``` org.eclipse.aether.SyncContext$FailedToAcquireLockException: Could not acquire shared lock for artifacts: ... in 900 SECONDS; consider using 'aether.syncContext.named.time' property to increase lock timeout ``` The artifacts it couldn't lock are a mix of `4.23.0.0-SNAPSHOT` jars (which this `4.20`-based PR doesn't produce) — the symptom of another concurrent job on the shared runner holding the `~/.m2/repository` aether lock. I verified the PR branch's root `pom.xml` is `<version>4.20.4.0-SNAPSHOT</version>`, matching `upstream/4.20`, and no code-side reason for the failure. The new push above will kick a fresh CI run that should clear the flake. ### Re: inline comment on `server/.../IpAddressManagerImpl.java:905` That file isn't touched by this PR — `gh api repos/apache/cloudstack/pulls/13059/files` confirms the only file changed is `plugins/storage/volume/adaptive/src/main/java/org/apache/cloudstack/storage/datastore/lifecycle/AdaptiveDataStoreLifeCycleImpl.java` (+7/-6). I suspect the inline anchor got misfiled via GitHub; happy to address any IP-related concern if you can re-anchor on the intended diff hunk (or let me know what you'd like me to look at). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
