sureshanaparti commented on code in PR #12702:
URL: https://github.com/apache/cloudstack/pull/12702#discussion_r3147138134
##########
plugins/user-authenticators/oauth2/src/main/java/org/apache/cloudstack/oauth2/api/command/ListOAuthProvidersCmd.java:
##########
@@ -59,6 +63,14 @@ public class ListOAuthProvidersCmd extends BaseListCmd
implements APIAuthenticat
@Parameter(name = ApiConstants.PROVIDER, type = CommandType.STRING,
description = "Name of the provider")
private String provider;
+ @Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID,
entityType = DomainResponse.class,
+ description = "List OAuth providers for a specific domain. Use -1
for global providers only.", since = "4.23.0")
+ private Long domainId;
+
+ @Parameter(name = ApiConstants.DOMAIN, type = CommandType.STRING,
+ description = "Domain path for domain-specific OAuth provider
lookup", since = "4.23.0")
+ private String domainPath;
Review Comment:
@Damans227 it seems domain id and domain path mutually exclusive, correct?
domain id takes higher precedence than path when both are passed (as per
_resolveDomainId()_0 ?
if both are not expected to pass from the api, validate and throw message
"Either domain id or path can be specified". OR mention in the description of
this parameter - "_Domain path for domain-specific OAuth provider lookup, this
is ignored when Domain Id is passed_"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
