jmsperu commented on issue #12899: URL: https://github.com/apache/cloudstack/issues/12899#issuecomment-4328677513
@harikrishna-patnala @abh1sar @JoaoJandre @weizhouapache — quick update. The full implementation has now landed on PR #13074 as 8 commits (~1.6K LoC across 11 files including the RFC). All review feedback from this thread is addressed; mapping table is in the PR description. Highlights: - Chain metadata lives in `backup_details` (per @JoaoJandre) — no schema change. - `nas.backup.full.every` (count-based) replaces the day-based interval (per @abh1sar). - Both full and incremental use `backup-begin` (full omits `<incremental>`); checkpoints created atomically via `--checkpointxml`. - Bitmap loss on VM restart is handled **lazily** at next backup (agent recreates the missing bitmap and emits `BITMAP_RECREATED=` so the orchestrator can record it). Avoided touching `VirtualMachineManager`/`StartCommand` to keep the blast radius small. - Cascade delete: middle incremental triggers a safe `qemu-img rebase` of its child onto the grandparent (child absorbs the to-be-deleted parent's blocks); full with children is refused unless `forced=true`. - 5 new smoke tests in `test_backup_recovery_nas.py` cover cadence, restore-from-incremental, delete-middle, refuse-delete-full-with-children, and stopped-VM fallback. Marking the PR ready for review now. Looking forward to your feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
