genegr commented on PR #13061: URL: https://github.com/apache/cloudstack/pull/13061#issuecomment-4335656501
Pushed `0608223402 ui: expose NVMe-TCP transport for FlashArray primary storage` on top of the round-1 backend fixes. Three small edits in `ui/src/views/infra/AddPrimaryStorage.vue`: - The protocol dropdown for the FlashArray provider previously pinned to `['FiberChannel']`, leaving NVMe-TCP only reachable via a hand-crafted URL. It now offers `['FiberChannel', 'NVMeTCP']`. Primera stays FC-only. - When `NVMeTCP` is the selected protocol, the submit handler appends `transport=nvme-tcp` to the FlashArray URL (using `?` or `&` based on whether the URL already has a query string), so the adaptive lifecycle pivot in `pickPoolType()` resolves `StoragePoolType.NVMeTCP` server-side. - The generic `Path` input — already hidden under the `FiberChannel` protocol — is also hidden under `NVMeTCP` so the FlashArray form looks consistent across transports. Verified end-to-end on a live FlashArray: registered a new pool through the form (Provider: Flash Array, Protocol: NVMeTCP), submitted to backend resolved `StoragePoolType.NVMeTCP` correctly, attached a volume, snapshot+revert produced the right NVMe EUI-128 `install_path`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
