jmsperu commented on PR #13090: URL: https://github.com/apache/cloudstack/pull/13090#issuecomment-4411331283
Pushed [f5f3db5ea3](https://github.com/apache/cloudstack/pull/13090/commits/f5f3db5ea3) addressing all review comments: **@sureshanaparti** — extracted the shared fence-action case into a new `scripts/vm/hypervisor/kvm/kvmha-fence.sh` sourced by both `kvmheartbeat.sh` and `kvmspheartbeat.sh`. Each caller now does: ```bash . "$(dirname "$0")/kvmha-fence.sh" fence_action "kvmheartbeat.sh" # script name passed for log tagging ``` Net -40 lines of duplication. **@NuxRo** — added `custom` action. Operator script path is configurable via `kvm.heartbeat.fence.custom.script` (default `/etc/cloudstack/agent/heartbeat-fence-custom.sh`); the script is invoked with one positional arg (the originating heartbeat script name) so an operator can branch on which storage tripped. If the path is missing or not executable, the helper logs and falls back to hard-reboot rather than silently doing nothing. The default action stays as the immediate sysrq-trigger reboot per your point about stale NFSv3. **@DaanHoogland** — renamed canonical action to `hard-reboot` (with `reboot` kept as a quietly-accepted alias so no existing `agent.properties` files break). Default value updated everywhere (AgentProperties.java + agent.properties + helper). **Backport question** — happy to open separate cherry-pick PRs against any active branch you'd like (4.21? 4.20?). Pure agent-side change, no DB schema, low risk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
