winterhazel commented on code in PR #13053:
URL: https://github.com/apache/cloudstack/pull/13053#discussion_r3223343940
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/IscsiAdmStorageAdaptor.java:
##########
@@ -123,21 +130,39 @@ public boolean connectPhysicalDisk(String volumeUuid,
KVMStoragePool pool, Map<S
}
}
Review Comment:
@rajiv-jain-netapp I missed this reply last week, sorry. I saw that you
already addressed this one and
https://github.com/apache/cloudstack/pull/13053#discussion_r3181886570 by
converting it to the format `if (!responseWasExpected(...)) { return false; }`,
which is exactly what I thought originally ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
