weizhouapache commented on code in PR #12446:
URL: https://github.com/apache/cloudstack/pull/12446#discussion_r3258709360
##########
server/src/main/java/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java:
##########
@@ -1003,14 +1003,11 @@ public void updateLBHealthChecks(Scheme scheme) throws
ResourceUnavailableExcept
private boolean isRollBackAllowedForProvider(LoadBalancerVO loadBalancer) {
Network network = _networkDao.findById(loadBalancer.getNetworkId());
List<Provider> provider =
_networkMgr.getProvidersForServiceInNetwork(network, Service.Lb);
- if (provider == null || provider.size() == 0) {
+ if (provider == null || provider.isEmpty()) {
Review Comment:
use `CollectionUtils.isEmpty()` ?
##########
server/src/main/java/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java:
##########
@@ -1003,14 +1003,11 @@ public void updateLBHealthChecks(Scheme scheme) throws
ResourceUnavailableExcept
private boolean isRollBackAllowedForProvider(LoadBalancerVO loadBalancer) {
Network network = _networkDao.findById(loadBalancer.getNetworkId());
List<Provider> provider =
_networkMgr.getProvidersForServiceInNetwork(network, Service.Lb);
- if (provider == null || provider.size() == 0) {
+ if (provider == null || provider.isEmpty()) {
return false;
}
- if (provider.get(0) == Provider.Netscaler || provider.get(0) ==
Provider.F5BigIp ||
- provider.get(0) == Provider.VirtualRouter || provider.get(0) ==
Provider.VPCVirtualRouter) {
- return true;
- }
- return false;
+ return provider.get(0) == Provider.Netscaler || provider.get(0) ==
Provider.F5BigIp ||
+ provider.get(0) == Provider.VirtualRouter || provider.get(0)
== Provider.VPCVirtualRouter;
Review Comment:
use `Arrays.asList(Provider.xx, Provider.xy...).contains(provider.get(0))` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
