weizhouapache commented on code in PR #13217:
URL: https://github.com/apache/cloudstack/pull/13217#discussion_r3286763103


##########
engine/components-api/src/main/java/com/cloud/ha/HighAvailabilityManager.java:
##########
@@ -76,7 +70,7 @@ public interface HighAvailabilityManager extends Manager {
         true, Cluster);
 
     ConfigKey<Boolean> KvmHAFenceHostIfHeartbeatFailsOnStorage = new 
ConfigKey<>("Advanced", Boolean.class, 
"kvm.ha.fence.on.storage.heartbeat.failure", "false",
-            "Proceed fencing the host even the heartbeat failed for only one 
storage pool", false, ConfigKey.Scope.Zone);
+            "Proceed fencing the host even the heartbeat failed for only one 
storage pool", true, ConfigKey.Scope.Zone);

Review Comment:
   this configuration has scope as Zone, but it looks like the zoneId is never 
considered



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to