jmsperu commented on PR #12872: URL: https://github.com/apache/cloudstack/pull/12872#issuecomment-4522825568
Closing as a duplicate of #12822 which fixes the same three issues (missing `exit 1` after cleanup in the running-VM Failed branch, missing `exit 1` after cleanup in the stopped-VM convert-failure branch, and resuming a paused VM in cleanup()) and has been APPROVED since March. One tiny improvement from this PR worth grafting onto #12822 in a follow-up: the `[[ -n "$VM" ]]` guard before `virsh domstate` — protects the cleanup path when VM isn't set yet. Sorry for the dup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
