jmsperu commented on PR #12843: URL: https://github.com/apache/cloudstack/pull/12843#issuecomment-4624604023
Friendly nudge — all CI checks are green and the PR is `MERGEABLE/CLEAN`. Whenever you have bandwidth, would appreciate a fresh look 🙏 Recap of what this adds to `nasbackup.sh`: - **`-t / --timeout` flag** with per-step kill-switch + cleanup trap so a hung `qemu-img` / `rsync` can't tie up a libvirt host indefinitely. - **Pre-flight free-space check** on the NAS target — refuse to start if there isn't headroom for a full VM image. - **Quiesce / `qemu-guest-agent` integration** before snapshotting so the guest filesystem is consistent. - **Defensive cleanup trap** that removes partial files on any error path. Backwards-compatible: invoking the script without `-t` / `--quiesce` behaves exactly as 4.22 did. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
