Copilot commented on code in PR #13424:
URL: https://github.com/apache/cloudstack/pull/13424#discussion_r3474706707
##########
scripts/vm/hypervisor/kvm/nasbackup.sh:
##########
@@ -196,10 +196,13 @@ backup_running_vm() {
# Print statistics
virsh -c qemu:///system domjobinfo $VM --completed
- du -sb $dest | cut -f1
-
- umount $mount_point
- rmdir $mount_point
+ backup_size=$(du -sb "$dest" 2>>$logFile | cut -f1) || { log -ne "WARNING:
du failed for $dest, reporting size
+ as 0"; backup_size=0; }
+
+ timeout $UNMOUNT_TIMEOUT umount "$mount_point" 2>>$logFile || { log
"WARNING: umount of $mount_point failed or timed out"; true; }
+ rmdir "$mount_point" 2>>$logFile || { log "WARNING: rmdir of $mount_point
failed"; true; }
Review Comment:
The warning string passed to `log` is split across two lines, which embeds a
literal newline (and leading spaces) into the log entry. Also, these new stderr
redirections don’t quote `$logFile`, which is inconsistent with the rest of
this script (e.g. `>> "$logFile"` in `log()` and elsewhere) and is
unnecessarily fragile if the path ever changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
