winterhazel commented on PR #13053:
URL: https://github.com/apache/cloudstack/pull/13053#issuecomment-4850290743
> This is what you are suggesting. -----> grantAccess(volumeInfo, destHost,
primaryDataStore); Map<String, String> details = new HashMap<>(); .... ----->
String managedStoreTarget =
ObjectUtils.defaultIfNull(volumeInfo.get_iScsiName(), volumeInfo.getUuid());
... primaryDataStore.setDetails(details); try {
motionSrv.copyAsync(srcTemplateInfo, destTemplateInfo, destHost, caller); ....
Yes, exactly.
> I will try this out today but we need sometime to test our workflows with
this change. Also we are raising a subsequent PR most probably today/tomorrow .
If you don't have concern, can I inlcude this change in that PR buying the time
to test workflows till that.
Ok, it is not a critical concern, so fine for me. Please test whether things
still work as expected with the change and include it in the subsequent PR.
---
@weizhouapache everything ok from my side on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
