Copilot commented on code in PR #13380:
URL: https://github.com/apache/cloudstack/pull/13380#discussion_r3526786194
##########
engine/schema/src/main/resources/META-INF/db/schema-42210to42300.sql:
##########
@@ -454,6 +454,15 @@ WHERE rule = 'quotaStatement' AND NOT EXISTS(SELECT 1 FROM
cloud.role_permission
-- Add description for secondary IP addresses
CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.nic_secondary_ips', 'description',
'VARCHAR(2048) DEFAULT NULL');
+--- Change nw_rate and mc_rate column types from smallint unsigned to int
unsigned to support larger rate values
+ALTER TABLE `cloud`.`service_offering`
+ MODIFY COLUMN `nw_rate` int unsigned DEFAULT 200 COMMENT 'network rate
throttle mbits/s',
+ MODIFY COLUMN `mc_rate` int unsigned DEFAULT 10 COMMENT 'mcast rate
throttle mbits/s';
+
+ALTER TABLE `cloud`.`network_offerings`
+ MODIFY COLUMN `nw_rate` int unsigned COMMENT 'network rate throttle
mbits/s',
+ MODIFY COLUMN `mc_rate` int unsigned COMMENT 'mcast rate throttle mbits/s';
Review Comment:
This migration updates `nw_rate`/`mc_rate` to `int unsigned` for upgrades,
but the fresh-install schema still defines these columns as `smallint unsigned`
(e.g. `setup/db/create-schema.sql:328-329` for `network_offerings` and
`setup/db/create-schema.sql:1509-1510` for `service_offering`). That means new
installations will still hit the ~65Gbps limit and won’t benefit from this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
