winterhazel commented on code in PR #13641:
URL: https://github.com/apache/cloudstack/pull/13641#discussion_r3617677600
##########
scripts/vm/hypervisor/kvm/nasbackup.sh:
##########
@@ -407,7 +407,7 @@ backup_stopped_vm() {
volUuid="${disk##*/}"
fi
output="$dest/$name.$volUuid.qcow2"
- if ! qemu-img convert -O qcow2 "$disk" "$output" > "$logFile" 2> >(cat
>&2); then
+ if ! qemu-img convert -O qcow2 "$disk" "$output" >> "$logFile" 2> >(cat
>&2); then
Review Comment:
It might make, but I would prefer to go with the simpler solution for the
4.23 RC2 instead to prevent any accidental regressions.
If we change it to use the `logger` utility, it would make more sense to
change the other 10 appends to `$logFile` in this file together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
