Copilot commented on code in PR #13671:
URL: https://github.com/apache/cloudstack/pull/13671#discussion_r3631863311
##########
ui/src/views/iam/SetupTwoFaAtUserProfile.vue:
##########
@@ -100,7 +100,7 @@
<a-row :gutter="12">
<a-col :md="24" :lg="20">
<a-form-item @finish="submitPin" v-ctrl-enter="submitPin"
name="code" ref="code">
- <a-input-password
+ <a-input
v-model:value="form.code"
placeholder="xxxxxx" />
Review Comment:
To reduce password-manager autofill/save issues and follow HTML conventions
for OTP fields, the 2FA input should include `autocomplete="one-time-code"`
(and ideally a numeric input hint).
##########
ui/src/views/dashboard/SetupTwoFaAtLogin.vue:
##########
@@ -109,7 +109,7 @@
<a-row :gutter="24">
<a-col :md="24" :lg="22">
<a-form-item @finish="submitPin" v-ctrl-enter="submitPin"
name="code" ref="code">
- <a-input-password
+ <a-input
v-model:value="form.code"
placeholder="xxxxxx" />
Review Comment:
To reduce password-manager autofill/save issues and follow HTML conventions
for OTP fields, the 2FA input should include `autocomplete="one-time-code"`
(and ideally a numeric input hint).
##########
ui/src/views/dashboard/VerifyTwoFa.vue:
##########
@@ -33,7 +33,7 @@
@finish="handleSubmit"
layout="vertical">
<a-form-item name="code" ref="code" style="text-align: center;">
- <a-input-password
+ <a-input
style="width: 500px"
v-model:value="form.code"
placeholder="xxxxxx" />
Review Comment:
To reduce password-manager autofill/save issues and follow HTML conventions
for OTP fields, the 2FA input should include `autocomplete="one-time-code"`
(and ideally a numeric input hint).
##########
ui/src/views/dashboard/VerifyTwoFa.vue:
##########
@@ -33,7 +33,7 @@
@finish="handleSubmit"
layout="vertical">
<a-form-item name="code" ref="code" style="text-align: center;">
- <a-input-password
+ <a-input
style="width: 500px"
v-model:value="form.code"
placeholder="xxxxxx" />
Review Comment:
After switching the 2FA code field to <a-input>, focusInput() still searches
for `input[type=password]` (see VerifyTwoFa.vue:86), so the 2FA input will no
longer be auto-focused on mount.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
